A simple Json implementation for future use. #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trams Yes. I need to split that PR into a few dependent PRs. I will address your comment from that PR here. :-). Thanks. |
RAMitchell
reviewed
Jul 29, 2019
There was a problem hiding this comment.
LGTM in general.
Some questions:
- Why specialize the file reader based on os?
- How is this implementation different from that provided by dmlc
- Why is the use of friend classes necessary? (I always ask this question as friend classes commonly indicate a shortcut instead or proper oo design)
|
@RAMitchell Removed the friend class. |
|
Since it doesn't modify existing code base, I incline to merge it here with all related comments addressed as now I'm working on the cudf intergration which will make use of this Json implementation. Any objection? @hcho3 @CodingCat |
hcho3
approved these changes
Jul 29, 2019
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable #4702 and #4683 (extracted from there). Other than serialization, the JSon implementation will be used to consume numpy array interface, and cuda array interface. This will benefit XGBoost as creating the generic interface will enable introp with lots of existing libraries (
arrow and friends, cupy, numba etc..) without creating specific C backend source code.A json implementation will the first part of on going effort for above described features. This PR doesn't touch any existing code base, can we consider merging it although it's not used by other code?